rob05c opened a new pull request #4938: URL: https://github.com/apache/trafficcontrol/pull/4938
It wasn't filtering DeliveryServiceServers, resulting in all servers with parents being included. Fixed to filter correctly. - [x] This PR is not related to any other Issue Manually tested, set DS MaxOriginConns, ran ORT, verified mid calculation matches manual calculation of DS setting divided by assigned Mids. No tests, logic is in the app side not the library so it can't be reasonably unit tested, and ORT doesn't have integration tests yet. No docs, no interface change. Includes changelog. ## Which Traffic Control components are affected by this PR? - Traffic Ops ORT ## What is the best way to verify this PR? Set Max Origin Connections on a Delivery Service that uses Mids. Manually calculate how many Reported Mids are parents of assigned Edges and divide the number you set by that, run ORT, verify hdr_rw_mid_yourds.config has the right number. ## If this is a bug fix, what versions of Traffic Control are affected? - 4.0.0 - 4.0.1 ## The following criteria are ALL met by this PR - [x] This PR includes tests OR I have explained why tests are unnecessary - [x] This PR includes documentation OR I have explained why documentation is unnecessary - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary - [x] This PR includes any and all required license headers - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details) ## Additional Information ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
