zrhoffman commented on a change in pull request #4943: URL: https://github.com/apache/trafficcontrol/pull/4943#discussion_r468098817
########## File path: infrastructure/cdn-in-a-box/cache/Dockerfile ########## @@ -29,7 +29,7 @@ EXPOSE 80 ADD https://ci.trafficserver.apache.org/RPMS/CentOS7/trafficserver-7.1.4-2.el7.x86_64.rpm /trafficserver.rpm ADD https://ci.trafficserver.apache.org/RPMS/CentOS7/trafficserver-devel-7.1.4-2.el7.x86_64.rpm /trafficserver-devel.rpm -RUN yum install -y bind-utils kyotocabinet-libs epel-release initscripts iproute net-tools nmap-ncat gettext autoconf automake libtool gcc-c++ cronie glibc-devel openssl-devel +RUN yum install -y bind-utils kyotocabinet-libs epel-release initscripts iproute net-tools nmap-ncat gettext autoconf automake libtool gcc-c++ cronie glibc-devel openssl-devel 'perl(JSON)' Review comment: The RPM spec requires it. If you don't include it, you get ``` > [20/20] RUN rpm -Uvh /$(basename infrastructure/cdn-in-a-box/cache/traffic_ops_ort.rpm) && rm /$(basename infrastructure/cdn-in-a-box/cache/traffic_ops_ort.rpm): #26 0.548 error: Failed dependencies: #26 0.548 perl(JSON) is needed by traffic_ops_ort-4.2.0-10848.7af9dd63.el7.x86_64 ``` I agree that we don't really need it. But since the other dependency validation is still useful, maybe we should remove that dependency from the spec when we make the project use the go version of ORT that was added in #4872. Either way, `perl(JSON)` was already being installed, its installation was just deferred until we installed the ORT RPM. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
