mitchell852 commented on a change in pull request #4910:
URL: https://github.com/apache/trafficcontrol/pull/4910#discussion_r470295227



##########
File path: traffic_ops/traffic_ops_golang/crconfig/deliveryservice.go
##########
@@ -491,12 +492,14 @@ order by dr.set_number asc
                if err := rows.Scan(&pattern, &ttype, &dstype, &setnum, 
&dsname); err != nil {
                        return nil, nil, errors.New("scanning deliveryservice 
regexes: " + err.Error())
                }
-
+               if _, ok := dsNameOrderMap[dsname]; !ok {

Review comment:
       do you think you can add a comment here to describe what you're doing 
(removing gaps)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to