ocket8888 commented on a change in pull request #4955:
URL: https://github.com/apache/trafficcontrol/pull/4955#discussion_r470316510
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryServiceStaticDnsEntry/form.deliveryServiceStaticDnsEntry.tpl.html
##########
@@ -50,9 +50,9 @@
<div class="form-group" ng-class="{'has-error':
hasError(dsStaticDnsEntryForm.ttl), 'has-feedback':
hasError(dsStaticDnsEntryForm.ttl)}">
<label for="ttl" class="control-label col-md-2 col-sm-2
col-xs-12">TTL *</label>
<div class="col-md-10 col-sm-10 col-xs-12">
- <input id="ttl" name="ttl" type="number"
class="form-control" ng-model="staticDnsEntry.ttl" min="0" step="1" required>
+ <input id="ttl" name="ttl" type="number"
class="form-control" ng-model="staticDnsEntry.ttl" ng-pattern="/^\d+$/"
required>
Review comment:
Why? `min` and `step` are native `input[type=number]` controls that work
within the browser. `ng-pattern` not only adds an event listener, but uses
userland scripting to do regular expression matching. It's slower and less
idiomatic than the native controls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
