ocket8888 commented on a change in pull request #4942:
URL: https://github.com/apache/trafficcontrol/pull/4942#discussion_r470835130
##########
File path: traffic_ops/testing/api/v3/origins_test.go
##########
@@ -16,26 +16,61 @@ package v3
*/
import (
+ "net/http"
"reflect"
"strings"
"testing"
"time"
+ "github.com/apache/trafficcontrol/lib/go-rfc"
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/lib/go-util"
toclient "github.com/apache/trafficcontrol/traffic_ops/client"
)
func TestOrigins(t *testing.T) {
WithObjs(t, []TCObj{CDNs, Types, Tenants, Parameters, Profiles,
Statuses, Divisions, Regions, PhysLocations, CacheGroups, Servers, Users,
Topologies, DeliveryServices, Coordinates, Origins}, func() {
+ currentTime := time.Now().UTC().Add(-5 * time.Second)
+ time := currentTime.Format(time.RFC1123)
+ var header http.Header
+ header = make(map[string][]string)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestOrigins(t)
+ UpdateTestOriginsWithHeaders(t, header)
GetTestOrigins(t)
NotFoundDeleteTest(t)
OriginTenancyTest(t)
VerifyPaginationSupport(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestOriginsWithHeaders(t, header)
})
}
+func UpdateTestOriginsWithHeaders(t *testing.T, header http.Header) {
+ firstOrigin := testData.Origins[0]
+ // Retrieve the origin by name so we can get the id for the Update
+ resp, _, err := TOSession.GetOriginByName(*firstOrigin.Name)
+ if err != nil {
+ t.Errorf("cannot GET origin by name: %v - %v",
*firstOrigin.Name, err)
+ }
+ remoteOrigin := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/cachegroups_test.go
##########
@@ -42,11 +42,43 @@ func TestCacheGroups(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestCacheGroups(t)
+ UpdateTestCacheGroupsWithHeaders(t, header)
GetTestCacheGroupsAfterChangeIMS(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestCacheGroupsWithHeaders(t, header)
})
}
+func UpdateTestCacheGroupsWithHeaders(t *testing.T, h http.Header) {
+ firstCG := testData.CacheGroups[0]
+ resp, _, err := TOSession.GetCacheGroupNullableByName(*firstCG.Name, h)
+ if err != nil {
+ t.Errorf("cannot GET CACHEGROUP by name: %v - %v",
*firstCG.Name, err)
+ }
+ cg := resp[0]
Review comment:
Same as above RE: segfault
##########
File path: traffic_ops/testing/api/v3/cdns_test.go
##########
@@ -32,12 +32,36 @@ func TestCDNs(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestCDNs(t)
+ UpdateTestCDNsWithHeaders(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestCDNsWithHeaders(t, header)
GetTestCDNs(t)
GetTestCDNsIMSAfterChange(t, header)
})
}
+func UpdateTestCDNsWithHeaders(t *testing.T, header http.Header) {
+ firstCDN := testData.CDNs[0]
+ // Retrieve the CDN by name so we can get the id for the Update
+ resp, _, err := TOSession.GetCDNByName(firstCDN.Name, header)
+ if err != nil {
+ t.Errorf("cannot GET CDN by name: '%s', %v", firstCDN.Name, err)
+ }
+ remoteCDN := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/phys_locations_test.go
##########
@@ -35,16 +35,41 @@ func TestPhysLocations(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestPhysLocations(t)
+ UpdateTestPhysLocationsWithHeaders(t, header)
GetTestPhysLocations(t)
GetTestPhysLocationsIMSAfterChange(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestPhysLocationsWithHeaders(t, header)
})
}
+func UpdateTestPhysLocationsWithHeaders(t *testing.T, header http.Header) {
+ firstPhysLocation := testData.PhysLocations[0]
+ // Retrieve the PhysLocation by name so we can get the id for the Update
+ resp, _, err := TOSession.GetPhysLocationByName(firstPhysLocation.Name,
header)
+ if err != nil {
+ t.Errorf("cannot GET PhysLocation by name: '%s', %v",
firstPhysLocation.Name, err)
+ }
+ remotePhysLocation := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/roles_test.go
##########
@@ -40,13 +40,38 @@ func TestRoles(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestRoles(t)
GetTestRoles(t)
+ UpdateTestRolesWithHeaders(t, header)
GetTestRolesIMSAfterChange(t, header)
VerifyGetRolesOrder(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestRolesWithHeaders(t, header)
})
}
+func UpdateTestRolesWithHeaders(t *testing.T, header http.Header) {
+ t.Logf("testData.Roles contains: %+v\n", testData.Roles)
+ firstRole := testData.Roles[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/statuses_test.go
##########
@@ -32,12 +32,41 @@ func TestStatuses(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestStatuses(t)
+ UpdateTestStatusesWithHeaders(t, header)
GetTestStatuses(t)
GetTestStatusesIMSAfterChange(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestStatusesWithHeaders(t, header)
})
}
+func UpdateTestStatusesWithHeaders(t *testing.T, header http.Header) {
+ firstStatus := testData.Statuses[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/staticdnsentries_test.go
##########
@@ -35,12 +35,35 @@ func TestStaticDNSEntries(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestStaticDNSEntries(t)
+ UpdateTestStaticDNSEntriesWithHeaders(t, header)
GetTestStaticDNSEntriesIMSAfterChange(t, header)
UpdateTestStaticDNSEntriesInvalidAddress(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestStaticDNSEntriesWithHeaders(t, header)
})
}
+func UpdateTestStaticDNSEntriesWithHeaders(t *testing.T, header http.Header) {
+ firstStaticDNSEntry := testData.StaticDNSEntries[0]
+ // Retrieve the StaticDNSEntries by name so we can get the id for the
Update
+ resp, _, err :=
TOSession.GetStaticDNSEntriesByHost(firstStaticDNSEntry.Host, header)
+ if err != nil {
+ t.Errorf("cannot GET StaticDNSEntries by name: '%s', %v",
firstStaticDNSEntry.Host, err)
+ }
+ remoteStaticDNSEntry := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/cdnfederations_test.go
##########
@@ -28,9 +32,37 @@ func TestCDNFederations(t *testing.T) {
WithObjs(t, []TCObj{CDNs, Types, Parameters, Tenants, CacheGroups,
Topologies, DeliveryServices, CDNFederations}, func() {
UpdateTestCDNFederations(t)
GetTestCDNFederations(t)
+ currentTime := time.Now().UTC().Add(-5 * time.Second)
+ time := currentTime.Format(time.RFC1123)
+ var header http.Header
+ header = make(map[string][]string)
+ header.Set(rfc.IfUnmodifiedSince, time)
+ UpdateTestCDNFederationsWithHeaders(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestCDNFederationsWithHeaders(t, header)
})
}
+func UpdateTestCDNFederationsWithHeaders(t *testing.T, h http.Header) {
+ for _, id := range fedIDs {
+ fed, _, err := TOSession.GetCDNFederationsByID("foo", id, h)
+ if err != nil {
+ t.Errorf("cannot GET federation by id: %v", err)
+ }
+ expectedCName := "new.cname."
+ fed.Response[0].CName = &expectedCName
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/deliveryservice_request_comments_test.go
##########
@@ -31,13 +31,34 @@ func TestDeliveryServiceRequestComments(t *testing.T) {
time := currentTime.Format(time.RFC1123)
var header http.Header
header = make(map[string][]string)
- header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestDeliveryServiceRequestComments(t)
+ UpdateTestDeliveryServiceRequestCommentsWithHeaders(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestDeliveryServiceRequestCommentsWithHeaders(t, header)
GetTestDeliveryServiceRequestComments(t)
GetTestDeliveryServiceRequestCommentsIMSAfterChange(t, header)
})
}
+func UpdateTestDeliveryServiceRequestCommentsWithHeaders(t *testing.T, header
http.Header) {
+ comments, _, err := TOSession.GetDeliveryServiceRequestComments(header)
+
+ firstComment := comments[0]
Review comment:
This'll segfault if len(comments) is < 1
##########
File path: traffic_ops/testing/api/v3/profiles_test.go
##########
@@ -30,18 +30,47 @@ func TestProfiles(t *testing.T) {
WithObjs(t, []TCObj{CDNs, Types, Profiles, Parameters}, func() {
CreateBadProfiles(t)
UpdateTestProfiles(t)
+ currentTime := time.Now().UTC().Add(-5 * time.Second)
+ time := currentTime.Format(time.RFC1123)
+ var header http.Header
+ header = make(map[string][]string)
+ header.Set(rfc.IfUnmodifiedSince, time)
+ UpdateTestProfilesWithHeaders(t, header)
GetTestProfilesIMS(t)
GetTestProfiles(t)
GetTestProfilesWithParameters(t)
ImportProfile(t)
CopyProfile(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestProfilesWithHeaders(t, header)
})
}
+func UpdateTestProfilesWithHeaders(t *testing.T, header http.Header) {
+ firstProfile := testData.Profiles[0]
+ // Retrieve the Profile by name so we can get the id for the Update
+ resp, _, err := TOSession.GetProfileByName(firstProfile.Name, header)
+ if err != nil {
+ t.Errorf("cannot GET Profile by name: %v - %v",
firstProfile.Name, err)
+ }
+ remoteProfile := resp[0]
+ remoteProfile.Description = "UPDATED"
Review comment:
To cover a corner-case where the description was already "UPDATED", this
should append with `+= "UPDATED"` so that it's always changed.
##########
File path: traffic_ops/testing/api/v3/divisions_test.go
##########
@@ -34,12 +34,38 @@ func TestDivisions(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestDivisions(t)
+ UpdateTestDivisionsWithHeaders(t, header)
GetTestDivisionsIMSAfterChange(t, header)
GetTestDivisions(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestDivisionsWithHeaders(t, header)
})
}
+func UpdateTestDivisionsWithHeaders(t *testing.T, header http.Header) {
+ firstDivision := testData.Divisions[0]
+ // Retrieve the Division by division so we can get the id for the Update
+ resp, _, err := TOSession.GetDivisionByName(firstDivision.Name, header)
+ if err != nil {
+ t.Errorf("cannot GET Division by division: %v - %v",
firstDivision.Name, err)
+ }
+ remoteDivision := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/coordinates_test.go
##########
@@ -33,11 +33,36 @@ func TestCoordinates(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestCoordinates(t)
+ UpdateTestCoordinatesWithHeaders(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestCoordinatesWithHeaders(t, header)
GetTestCoordinatesIMSAfterChange(t, header)
})
}
+func UpdateTestCoordinatesWithHeaders(t *testing.T, header http.Header) {
+ firstCoord := testData.Coordinates[0]
+ resp, _, err := TOSession.GetCoordinateByName(firstCoord.Name, nil)
+ if err != nil {
+ t.Errorf("cannot GET Coordinate by name: %v - %v",
firstCoord.Name, err)
+ }
+ coord := resp[0]
Review comment:
Same as above RE: segfault
##########
File path: traffic_ops/testing/api/v3/regions_test.go
##########
@@ -33,17 +33,41 @@ func TestRegions(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestRegions(t)
+ UpdateTestRegionsWithHeaders(t, header)
GetTestRegions(t)
GetTestRegionsIMSAfterChange(t, header)
DeleteTestRegionsByName(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestRegionsWithHeaders(t, header)
})
}
+func UpdateTestRegionsWithHeaders(t *testing.T, header http.Header) {
+ firstRegion := testData.Regions[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/profiles_test.go
##########
@@ -30,18 +30,47 @@ func TestProfiles(t *testing.T) {
WithObjs(t, []TCObj{CDNs, Types, Profiles, Parameters}, func() {
CreateBadProfiles(t)
UpdateTestProfiles(t)
+ currentTime := time.Now().UTC().Add(-5 * time.Second)
+ time := currentTime.Format(time.RFC1123)
+ var header http.Header
+ header = make(map[string][]string)
+ header.Set(rfc.IfUnmodifiedSince, time)
+ UpdateTestProfilesWithHeaders(t, header)
GetTestProfilesIMS(t)
GetTestProfiles(t)
GetTestProfilesWithParameters(t)
ImportProfile(t)
CopyProfile(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestProfilesWithHeaders(t, header)
})
}
+func UpdateTestProfilesWithHeaders(t *testing.T, header http.Header) {
+ firstProfile := testData.Profiles[0]
+ // Retrieve the Profile by name so we can get the id for the Update
+ resp, _, err := TOSession.GetProfileByName(firstProfile.Name, header)
+ if err != nil {
+ t.Errorf("cannot GET Profile by name: %v - %v",
firstProfile.Name, err)
+ }
+ remoteProfile := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/profiles_test.go
##########
@@ -30,18 +30,47 @@ func TestProfiles(t *testing.T) {
WithObjs(t, []TCObj{CDNs, Types, Profiles, Parameters}, func() {
CreateBadProfiles(t)
UpdateTestProfiles(t)
+ currentTime := time.Now().UTC().Add(-5 * time.Second)
+ time := currentTime.Format(time.RFC1123)
+ var header http.Header
+ header = make(map[string][]string)
+ header.Set(rfc.IfUnmodifiedSince, time)
+ UpdateTestProfilesWithHeaders(t, header)
GetTestProfilesIMS(t)
GetTestProfiles(t)
GetTestProfilesWithParameters(t)
ImportProfile(t)
CopyProfile(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestProfilesWithHeaders(t, header)
})
}
+func UpdateTestProfilesWithHeaders(t *testing.T, header http.Header) {
+ firstProfile := testData.Profiles[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/parameters_test.go
##########
@@ -37,12 +37,37 @@ func TestParameters(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestParameters(t)
+ UpdateTestParametersWithHeaders(t, header)
GetTestParameters(t)
GetTestParametersIMSAfterChange(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestParametersWithHeaders(t, header)
})
}
+func UpdateTestParametersWithHeaders(t *testing.T, header http.Header) {
+ firstParameter := testData.Parameters[0]
+ // Retrieve the Parameter by name so we can get the id for the Update
+ resp, _, err := TOSession.GetParameterByName(firstParameter.Name, nil)
+ if err != nil {
+ t.Errorf("cannot GET Parameter by name: %v - %v",
firstParameter.Name, err)
+ }
+ remoteParameter := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/regions_test.go
##########
@@ -33,17 +33,41 @@ func TestRegions(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestRegions(t)
+ UpdateTestRegionsWithHeaders(t, header)
GetTestRegions(t)
GetTestRegionsIMSAfterChange(t, header)
DeleteTestRegionsByName(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestRegionsWithHeaders(t, header)
})
}
+func UpdateTestRegionsWithHeaders(t *testing.T, header http.Header) {
+ firstRegion := testData.Regions[0]
+ // Retrieve the Region by region so we can get the id for the Update
+ resp, _, err := TOSession.GetRegionByName(firstRegion.Name, header)
+ if err != nil {
+ t.Errorf("cannot GET Region by region: %v - %v",
firstRegion.Name, err)
+ }
+ remoteRegion := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/staticdnsentries_test.go
##########
@@ -35,12 +35,35 @@ func TestStaticDNSEntries(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestStaticDNSEntries(t)
+ UpdateTestStaticDNSEntriesWithHeaders(t, header)
GetTestStaticDNSEntriesIMSAfterChange(t, header)
UpdateTestStaticDNSEntriesInvalidAddress(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestStaticDNSEntriesWithHeaders(t, header)
})
}
+func UpdateTestStaticDNSEntriesWithHeaders(t *testing.T, header http.Header) {
+ firstStaticDNSEntry := testData.StaticDNSEntries[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/statuses_test.go
##########
@@ -32,12 +32,41 @@ func TestStatuses(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestStatuses(t)
+ UpdateTestStatusesWithHeaders(t, header)
GetTestStatuses(t)
GetTestStatusesIMSAfterChange(t, header)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestStatusesWithHeaders(t, header)
})
}
+func UpdateTestStatusesWithHeaders(t *testing.T, header http.Header) {
+ firstStatus := testData.Statuses[0]
+ if firstStatus.Name == nil {
+ t.Fatal("cannot update test statuses: first test data status
must have a name")
+ }
+
+ // Retrieve the Status by name so we can get the id for the Update
+ resp, _, err := TOSession.GetStatusByName(*firstStatus.Name, header)
+ if err != nil {
+ t.Errorf("cannot GET Status by name: %v - %v",
firstStatus.Name, err)
+ }
+ remoteStatus := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/roles_test.go
##########
@@ -40,13 +40,38 @@ func TestRoles(t *testing.T) {
var header http.Header
header = make(map[string][]string)
header.Set(rfc.IfModifiedSince, time)
+ header.Set(rfc.IfUnmodifiedSince, time)
UpdateTestRoles(t)
GetTestRoles(t)
+ UpdateTestRolesWithHeaders(t, header)
GetTestRolesIMSAfterChange(t, header)
VerifyGetRolesOrder(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestRolesWithHeaders(t, header)
})
}
+func UpdateTestRolesWithHeaders(t *testing.T, header http.Header) {
+ t.Logf("testData.Roles contains: %+v\n", testData.Roles)
+ firstRole := testData.Roles[0]
+ // Retrieve the Role by role so we can get the id for the Update
+ resp, _, status, err := TOSession.GetRoleByName(*firstRole.Name, header)
+ t.Log("Status Code: ", status)
+ if err != nil {
+ t.Errorf("cannot GET Role by role: %v - %v", firstRole.Name,
err)
+ }
+ t.Logf("got response: %+v\n", resp)
+ remoteRole := resp[0]
Review comment:
Same as above RE: Segfault
##########
File path: traffic_ops/testing/api/v3/profiles_test.go
##########
@@ -30,18 +30,47 @@ func TestProfiles(t *testing.T) {
WithObjs(t, []TCObj{CDNs, Types, Profiles, Parameters}, func() {
CreateBadProfiles(t)
UpdateTestProfiles(t)
+ currentTime := time.Now().UTC().Add(-5 * time.Second)
+ time := currentTime.Format(time.RFC1123)
+ var header http.Header
+ header = make(map[string][]string)
+ header.Set(rfc.IfUnmodifiedSince, time)
+ UpdateTestProfilesWithHeaders(t, header)
GetTestProfilesIMS(t)
GetTestProfiles(t)
GetTestProfilesWithParameters(t)
ImportProfile(t)
CopyProfile(t)
+ header = make(map[string][]string)
+ etag := rfc.ETag(currentTime)
+ header.Set(rfc.IfMatch, etag)
+ UpdateTestProfilesWithHeaders(t, header)
})
}
+func UpdateTestProfilesWithHeaders(t *testing.T, header http.Header) {
+ firstProfile := testData.Profiles[0]
+ // Retrieve the Profile by name so we can get the id for the Update
+ resp, _, err := TOSession.GetProfileByName(firstProfile.Name, header)
+ if err != nil {
+ t.Errorf("cannot GET Profile by name: %v - %v",
firstProfile.Name, err)
+ }
+ remoteProfile := resp[0]
+ remoteProfile.Description = "UPDATED"
Review comment:
On the other hand, I don't know if that matters for the purposes of this
test. But if it doesn't, then why bother changing it at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
