rob05c opened a new pull request #4990: URL: https://github.com/apache/trafficcontrol/pull/4990
Adds support for Multiple Interfaces to ORT. Includes getting the right interface from the Server, as well as setting the records.config `outgoing_ip` setting to the Service Interface(s). This also refactors remap.config and parent.config, to use standard API objects. Those were already in the works and had a PR, and multi-interface support would cause huge conflicts, as well as much of the same code to review. A single PR both avoids conflicts and makes it less code to review. No changelog, no interface change. No docs, multi-interface servers is already documented. Includes unit tests. Manually tested, config generates the same before and after this change for our production servers, as well as our test environment with Topologies. - [x] This PR is not related to any other Issue ## Which Traffic Control components are affected by this PR? - Traffic Ops ORT ## What is the best way to verify this PR? Run unit tests. Generate config with ORT before this change, build this and generate new config, diff and verify there are no semantic changes, except the additional record.config entry. ## If this is a bug fix, what versions of Traffic Control are affected? Not a bug fix. ## The following criteria are ALL met by this PR - [x] This PR includes tests OR I have explained why tests are unnecessary - [x] This PR includes documentation OR I have explained why documentation is unnecessary - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary - [x] This PR includes any and all required license headers - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details) ## Additional Information ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
