ezelkow1 commented on a change in pull request #4993:
URL: https://github.com/apache/trafficcontrol/pull/4993#discussion_r480420666
##########
File path: traffic_monitor/cache/astats_test.go
##########
@@ -60,14 +57,11 @@ func TestAstatsCSV(t *testing.T) {
pl := &poller.HTTPPollCtx{HTTPHeader: http.Header{}}
ctx := interface{}(pl)
ctx.(*poller.HTTPPollCtx).HTTPHeader.Set("Content-Type", "text/csv")
- _, thismap, err := astatsParse("testCache", file, ctx)
+ _, _, err = astatsParse("testCache", file, ctx)
Review comment:
That being said I could add some value checks in the map just to test
for existence, but Id prefer to do that in the next PR. I plan on working on a
follow up directly after this is merged to add similar support to
stats_over_http, but that is dependent on this baseline being in since it needs
the Accept support and changes to allow the contexts to be passed around
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
