alficles commented on a change in pull request #5004: URL: https://github.com/apache/trafficcontrol/pull/5004#discussion_r486657948
########## File path: infrastructure/docker/build/Dockerfile-tsb ########## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM golang:1.13 as tsb-build +RUN mkdir -p /go/src/github.com/comcast/tsb && cd /go/src/github.com/comcast/tsb && git init && git remote add origin https://github.com/comcast/tsb && git fetch --depth=1 origin 58e38cc84edf2415c05e5c1e78b242c03fa675fa && git reset --hard FETCH_HEAD +RUN CGOENABLED=0 go install github.com/comcast/tsb + +FROM centos:7 +MAINTAINER [email protected] + +RUN yum -y install git sudo +#ADD https://github.com/docker/compose/releases/download/1.26.2/docker-compose-Linux-x86_64 /usr/bin/docker-compose Review comment: It's not precisely "not needed" entirely. But the existing use case doesn't require mounting the docker socket. I left it in intentionally to show where that would normally come from. I could probably have put a comment in there explaining, though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
