zrhoffman opened a new issue #5042: URL: https://github.com/apache/trafficcontrol/issues/5042
<!-- ************ STOP!! ************ If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact the Apache Software Foundation Security Team at [email protected] and follow the guidelines at https://www.apache.org/security/ regarding vulnerability disclosure. - For *SUPPORT QUESTIONS*, use the [Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/). - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. --> ## I'm submitting a ... <!-- delete all those that don't apply --> <!--- security vulnerability (STOP!! - see above)--> - improvement request (usability, performance, tech debt, etc.) ## Traffic Control components affected ... <!-- delete all those that don't apply --> - CI tests ## Current behavior: <!-- Describe how the bug manifests / how the current features are insufficient. --> Maven dependency caching was added in #5036 because GitHub Actions apparently started rate-limiting downloads. NPM dependencies are not cached in our *CDN-in-a-Box CI* workflow, which includes building Traffic Portal. In the future, if more NPM dependencies are added, we risk the job (and consequently, the workflow) failing to build. ## Expected / new behavior: <!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control --> Caching NPM dependencies as described at https://github.com/actions/cache/blob/main/examples.md#node---npm ## Anything else: <!-- e.g. stacktraces, related issues, suggestions how to fix --> To get around the fact that our components are built in Docker containers, the `docker-compose.yml` for building RPMs [mounts `/.m2` from the root directory of the repo](https://github.com/apache/trafficcontrol/blob/master/infrastructure/docker/build/docker-compose.yml#L68) for later reuse. We should do something similar for `/traffic_portal/node_modules`. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
