zrhoffman commented on a change in pull request #5017:
URL: https://github.com/apache/trafficcontrol/pull/5017#discussion_r491155927
##########
File path: traffic_ops/testing/api/v2/tc-fixtures.json
##########
@@ -717,6 +717,12 @@
"typeName": "HOST_REGEXP",
"setNumber": 1,
"pattern" : ".*"
+ },
+ {
+ "dsName": "ds1",
+ "typeName": "HOST_REGEXP",
+ "setNumber": 3,
+ "pattern" : ""
}
Review comment:
I see, by putting it in `tc-fixtures.json`, you get all of the IDs for
different tables it is related to. In the future, it might be nice to have a
separate JSON file for invalid fixtures for negative tests so we can assume
that everything in `tc-fixtures.json` is valid, but we don't have that yet, so
the way you did it makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
