zrhoffman commented on a change in pull request #5016: URL: https://github.com/apache/trafficcontrol/pull/5016#discussion_r491193151
########## File path: traffic_ops/testing/api/v3/topologies_queue_update_test.go ########## @@ -0,0 +1,127 @@ +package v3 + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import ( + "github.com/apache/trafficcontrol/lib/go-tc" Review comment: Line put below all the other imports, with a blank line in between, in 652b930b3e ########## File path: lib/go-tc/topologies.go ########## @@ -47,3 +47,25 @@ type TopologiesResponse struct { Response []Topology `json:"response"` Alerts } + +// TopologiesQueueUpdateRequest encodes the request data for the POST +// topologies/{{name}}/queue_update endpoint. +type TopologiesQueueUpdateRequest struct { + Action string `json:"action"` + CDNID int64 `json:"cdnId"` +} + +// TopologiesQueueUpdate encodes the response data for the POST Review comment: Changed to `TopologiesQueueUpdateResponse` in a3aba0f95c ########## File path: CHANGELOG.md ########## @@ -9,7 +9,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Traffic Ops API v3 - Added an optional readiness check service to cdn-in-a-box that exits successfully when it is able to get a `200 OK` from all delivery services - [Flexible Topologies (in progress)](https://github.com/apache/trafficcontrol/blob/master/blueprints/flexible-topologies.md) - - Traffic Ops: Added an API 3.0 endpoint, /api/3.0/topologies, to create, read, update and delete flexible topologies. + - Traffic Ops: Added an API 3.0 endpoint, `GET /api/3.0/topologies`, to create, read, update and delete flexible topologies. + - Traffic Ops: Added an API 3.0 endpoint, `POST /api/3.0/topologyes/{name}/queue_update`, to queue or dequeue updates for all servers assigned to the Cachegroups in a given Topology. Review comment: Typo fixed in 5d6f5b919b ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
