ocket8888 opened a new pull request #5077:
URL: https://github.com/apache/trafficcontrol/pull/5077


   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue
   
   This PR adds a new check to GHA for Go Format problems. It outputs 
annotations containing a diff chunk at each problematic part of the codebase. 
It also adds a supporting python script for the action (which could potentially 
be used with other linters, Pylint, ESLint etc.) and a badge for the action to 
the repository's README.
   
   ## Which Traffic Control components are affected by this PR?
   - CI tests
   
   ## What is the best way to verify this PR?
   Make a branch from this PR's branch, make some go-fmt invalidating change 
and push. Also, as it happens, there is currently a file in violation of `go 
fmt` in the `tc3` tool, so in addition to whatever change you make you should 
see that, too.
   
   The Python script comes with some doctests, so to test it run `python -m 
doctest path/to/parse_diffs.py`.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x] This PR includes documentation in the form of docstrings
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to