ocket8888 commented on a change in pull request #5078:
URL: https://github.com/apache/trafficcontrol/pull/5078#discussion_r497200016
##########
File path: .github/actions/build-ciab/build-ciab.js
##########
@@ -32,10 +32,7 @@ function moveRPMs() {
.filter(item => fs.lstatSync(item).isDirectory()) // get a list
of directories within dist
.flatMap(directory => fs.readdirSync(directory).map(item =>
path.join(directory, item))) // list files within those directories
.filter(item => /\.rpm$/.test(item)) // get a list of RPMs
- .map(rpm => {
- fs.renameSync(rpm, rpm.replace(new RegExp('.*/'), ''));
- return rpm;
- }); // move the RPMs to the dist folder
+ .map(rpm => fs.renameSync(rpm, rpm.replace(new RegExp('.*/'),
''))); // move the RPMs to the dist folder
Review comment:
Will this run on Windows executors? I mean, I know it _won't_ for the
foreseeable future, but if you tried would it work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
