mitchell852 edited a comment on pull request #5044: URL: https://github.com/apache/trafficcontrol/pull/5044#issuecomment-701464151
I think this PR is going to have to be closed and here's my thinking. Scenario: User creates a "job" (invalidate content request) to invalidate `images/foo.jpg` with a 48hr TTL and the rule looks like this in regex_revalidate.config: ``` http://origin\.tld/images/foo\.jpg 1601650896 ``` An hour later, a request for `images/foo.jpg` comes in, the rule is applied, new foo.jpg is fetched from the origin. Works like a charm. The next day, the user wants to invalidate `images/foo.jpg` AGAIN so they create another rule with the same regex and a TTL of 48hrs. Now regex_revalidate.config looks like: ``` http://origin\.tld/images/foo\.jpg 1601564496 <-- this rule was already applied and will not be applied again http://origin\.tld/images/foo\.jpg 1601823696 ``` ^^ These 2 rules "overlap". I'm pretty sure that is a valid/common scenario, therefore, preventing duplicate/overlapping rules may prevent users from doing normal things. Imagine a user creates a rule with a 720hr TTL (30 days). This PR would limit them to doing only one revalidate for the regex for the entire 30 days....which is probably a bad thing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
