mattjackson220 commented on a change in pull request #5083:
URL: https://github.com/apache/trafficcontrol/pull/5083#discussion_r497709659



##########
File path: 
traffic_portal/app/src/common/modules/form/deliveryService/edit/FormEditDeliveryServiceController.js
##########
@@ -161,6 +166,30 @@ var FormEditDeliveryServiceController = 
function(deliveryService, origin, topolo
        };
 
        $scope.save = function(deliveryService) {
+               if (deliveryService.sslKeyVersion !== null && 
deliveryService.sslKeyVersion !== 0 &&

Review comment:
       I dont think this page will ever have deliveryService.sslKeyVersion !== 
null. I think that /deliveryservices endpoint doesnt return the ssl key 
version.  I dont think we know that until we are onto the ssl keys page itself. 
 TP still fails to updated the DS but just returns a Forbidden message




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to