mitchell852 commented on a change in pull request #5092:
URL: https://github.com/apache/trafficcontrol/pull/5092#discussion_r498957580
##########
File path: traffic_portal/app/src/common/service/utils/ServerUtils.js
##########
@@ -67,6 +67,24 @@ var ServerUtils = function($window, propertiesModel,
userModel) {
);
};
+ // Takes a response object from TO and converts all of its alerts to
messages acceptable by the messageModel
+ this.convertResponseToMessages = function(response) {
Review comment:
> It sounds like it would be a better idea to have that method combine
all the alerts with the same level instead
Maybe. Or just leave as it is...meaning. if 5 "warning" messages are
returned from server, just let TP pop 5 messages. seems fine to me. it's kind
of a rare thing that you'd ever see that but TP can handle it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
