ocket8888 commented on a change in pull request #5095:
URL: https://github.com/apache/trafficcontrol/pull/5095#discussion_r499715993
##########
File path: .github/actions/go-test/entrypoint.sh
##########
@@ -18,16 +18,26 @@
set -e
+download_go() {
+ go_version="$(cat "${GITHUB_WORKSPACE}/GO_VERSION")"
+ wget -O go.tar.gz
"https://dl.google.com/go/go${go_version}.linux-amd64.tar.gz";
+ tar -C /usr/local -xzf go.tar.gz
+ rm go.tar.gz
+ export PATH="${PATH}:${GOROOT}/bin"
+ go version
Review comment:
this one too
##########
File path: .github/actions/go-fmt/entrypoint.sh
##########
@@ -18,6 +18,16 @@
set -e
+download_go() {
+ go_version="$(cat "${GITHUB_WORKSPACE}/GO_VERSION")"
+ wget -O go.tar.gz
"https://dl.google.com/go/go${go_version}.linux-amd64.tar.gz";
+ tar -C /usr/local -xzf go.tar.gz
+ rm go.tar.gz
+ export PATH="${PATH}:${GOROOT}/bin"
+ go version
Review comment:
I know we don't mandate one or the other for shell scripts, but the rest
of this file _does_ already use tabs for indentation...
##########
File path: .github/actions/to-integration-tests/entrypoint.sh
##########
@@ -16,12 +16,22 @@
# specific language governing permissions and limitations
# under the License.
-GOPATH="$(mktemp -d)"
-SRCDIR="$GOPATH/src/github.com/apache"
-mkdir -p "$SRCDIR"
-ln -s "$PWD" "$SRCDIR/trafficcontrol"
+download_go() {
+ go_version="$(cat "${GITHUB_WORKSPACE}/GO_VERSION")"
+ wget -O go.tar.gz
"https://dl.google.com/go/go${go_version}.linux-amd64.tar.gz";
+ tar -C /usr/local -xzf go.tar.gz
+ rm go.tar.gz
+ export PATH="${PATH}:${GOROOT}/bin"
+ go version
Review comment:
and this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
