ocket8888 commented on a change in pull request #5094:
URL: https://github.com/apache/trafficcontrol/pull/5094#discussion_r500609119
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
##########
@@ -266,6 +266,14 @@ func createV30(w http.ResponseWriter, r *http.Request, inf
*api.APIInfo, ds tc.D
deepCachingType = ds.DeepCachingType.String() // necessary,
because DeepCachingType's default needs to insert the string, not "", and Query
doesn't call .String().
}
+ if ds.Topology != nil {
Review comment:
> ...in the meantime, can we refactor the check into a shared function
that is used in create() as well as update()?
Yeah, for sure.
> ... should we add a // TODO: ... for that?
It'll mean changing the
`github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api.ParseValidator`
interface, but I think that'd be a worthwhile change. So: yes, and that's
where I'll put it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
