mitchell852 commented on pull request #5128:
URL: https://github.com/apache/trafficcontrol/pull/5128#issuecomment-709370401


   > Look at the `expectedHostnames` array. If it encounters a host that is not 
in that array, it fails on line 458. In the excerpt of the API tests I posted:
   > 
   > ```go
   > servers_test.go:458: expected hostnames map[atlanta-mid-16:true 
edge1-cdn1-cg3:true edge2-cdn1-cg3:true], actual atlanta-mid-17 actual:
   > ```
   > 
   > It means that the only servers it expected in the response were
   > 
   > * atlanta-mid-16
   > * edge1-cdn1-cg3
   > * edge2-cdn1-cg3
   > 
   > but it found `atlanta-mid-17` as well, so it failed.
   > 
   > That ` actual:` part at the end of the message is extra and should be 
removed (my bad).
   > 
   > So, look at whether `atlanta-mid-17` should be included in the result. If 
it should, add it to the array. If it should not, then there's a bug that 
should be fixed. I would recommend against simply moving it to a different 
cachegroup like 
[1026a81](https://github.com/apache/trafficcontrol/commit/1026a81bb621044a8e6c43b0670c4e5ab13597e6)
 does.
   
   honestly, i could not find that in the GHA output....


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to