mitchell852 commented on a change in pull request #5128:
URL: https://github.com/apache/trafficcontrol/pull/5128#discussion_r505740139
##########
File path: traffic_ops/traffic_ops_golang/server/servers.go
##########
@@ -1009,7 +1013,12 @@ func getMidServers(edgeIDs []int, servers
map[int]tc.ServerNullable, tx *sqlx.Tx
WHERE s.id IN (?)))
`
- query, args, err := sqlx.In(q, edgeIDs)
+ if cdnID > 0 {
+ q += ` AND s.cdn_id = ?`
+ filters = append(filters, cdnID)
+ }
Review comment:
i think you're missing the point here. ONLY filter by cdn if cdn is
passed in...
sometimes you don't want to filter by cdn...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
