ocket8888 commented on a change in pull request #5101:
URL: https://github.com/apache/trafficcontrol/pull/5101#discussion_r508880602
##########
File path: test/router/dnssec/dnssec_suite_test.go
##########
@@ -20,14 +20,14 @@ package dnssec_test
*/
import (
- . "github.com/onsi/ginkgo"
- . "github.com/onsi/gomega"
+ // _ "github.com/onsi/ginkgo"
+ // _ "github.com/onsi/gomega"
Review comment:
Actually, based on what I said below, I think I should change those back
to `.` imports. `.` and `_` don't do the same thing for imports, which is what
I thought when I changed that. When you use `.` it imports all symbols from the
package into the current namespace, which might be necessary for the code below
to compile (although it actually didn't compile). So if I'm leaving in the
below code, I'll wanna fix this to just be commented-out and not also changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
