mitchell852 opened a new pull request #5198: URL: https://github.com/apache/trafficcontrol/pull/5198
- [x] This PR fixes #5188 ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best way to verify this PR? - enable dsRequests in traffic_portal_properties.json, set overrideRole=admin, login as an admin user. - make a change to an existing DS that you know will fail backend validation (see #5188 for example), fulfill DSR immediately. ensure error message is displayed in TP and a DSR is created but NOT marked as complete. ## If this is a bug fix, what versions of Traffic Control are affected? - master (5940129) - 4.1.0 - 5.0.0 (RC1) ## The following criteria are ALL met by this PR - [ ] This PR includes tests OR I have explained why tests are unnecessary - [ ] This PR includes documentation OR I have explained why documentation is unnecessary - [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary - [x] This PR includes any and all required license headers - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
