mitchell852 edited a comment on pull request #5225: URL: https://github.com/apache/trafficcontrol/pull/5225#issuecomment-719040325
should there be any validation on name like alphanumerics and dashes? no spaces. underscores....not really sure. i guess are there any downstream systems that will barf with invalid characters? i would probably recommend adding the same TP field validation that xml-id has: ``` pattern="[a-z0-9]([a-z0-9\-]*[a-z0-9])?" ``` ``` <small class="input-error" ng-show="hasPropertyError(generalConfig.xmlId, 'pattern')">Must be a valid DNS label (no special characters, capital letters, periods, underscores, or spaces and cannot begin or end with a hyphen)</small> ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
