ocket8888 commented on a change in pull request #5183:
URL: https://github.com/apache/trafficcontrol/pull/5183#discussion_r514608260
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/request/requests.go
##########
@@ -92,6 +92,7 @@ func (req *TODeliveryServiceRequest) Read(h http.Header,
useIMS bool) ([]interfa
"author": dbhelpers.WhereColumnInfo{Column: "a.username"},
"authorId": dbhelpers.WhereColumnInfo{Column: "r.author_id",
Checker: api.IsInt},
"changeType": dbhelpers.WhereColumnInfo{Column:
"r.change_type"},
+ "createdAt": dbhelpers.WhereColumnInfo{Column: "r.created_at"},
Review comment:
It might be a niche use-case, but IMO it's weirder to be able to filter
by all properties except one.
The really tough question for me is one you don't need to answer here: when
olderThan and newerThan are implemented for this endpoint, will the use
createdAt - which makes the most sense - or lastUpdated - which is what every
other endpoint will use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
