rob05c commented on a change in pull request #5247:
URL: https://github.com/apache/trafficcontrol/pull/5247#discussion_r525515786
##########
File path: lib/go-atscfg/parentdotconfig.go
##########
@@ -1219,46 +1257,38 @@ func unavailableServerRetryResponsesValid(s string)
bool {
return re.MatchString(s)
}
-// HasRequiredCapabilities returns whether the given caps has all the required
capabilities in the given reqCaps.
-func HasRequiredCapabilities(caps map[ServerCapability]struct{}, reqCaps
map[ServerCapability]struct{}) bool {
- for reqCap, _ := range reqCaps {
- if _, ok := caps[reqCap]; !ok {
- return false
- }
- }
- return true
-}
-
-func GetOriginServersAndProfileCaches(
- cgServers map[int]tc.ServerNullable,
+// GetOriginServersAndProfileCaches returns the origin servers, ProfileCaches,
any warnings, and any error.
Review comment:
Fixed
##########
File path: lib/go-atscfg/parentdotconfig.go
##########
@@ -1408,32 +1442,33 @@ func GetParentConfigProfileParams(
}
parentConfigServerCacheProfileParams[*cgServer.Profile] =
profileCache
}
- return parentConfigServerCacheProfileParams
+ return parentConfigServerCacheProfileParams, warnings
}
-// GetDSOrigins takes a map[deliveryServiceID]DeliveryService, and returns a
map[DeliveryServiceID]OriginURI.
-func GetDSOrigins(dses map[int]tc.DeliveryServiceNullableV30)
(map[int]*OriginURI, error) {
- dsOrigins := map[int]*OriginURI{}
+// GetDSOrigins takes a map[deliveryServiceID]DeliveryService, and returns a
map[DeliveryServiceID]OriginURI, any warnings, and any error.
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
