rob05c commented on a change in pull request #5345:
URL: https://github.com/apache/trafficcontrol/pull/5345#discussion_r541119890
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -179,6 +189,13 @@ type DeliveryServiceNullableV30 struct {
ServiceCategory *string `json:"serviceCategory"
db:"service_category"`
}
+type DeliveryServiceV31 struct {
+ DeliveryServiceV30
+ MaxRequestHeaderSize *int `json:"maxRequestHeaderSize"
db:"max_request_header_size"`
Review comment:
Would you object to changing this to `MaxRequestHeaderBytes`?
I think it makes it easier, so people don't have to look up the
documentation to know the units, and don't assume the wrong unit and make a
mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
