ocket8888 commented on a change in pull request #5464:
URL: https://github.com/apache/trafficcontrol/pull/5464#discussion_r563044323
##########
File path: test/fakeOrigin/build/build_rpm.sh
##########
@@ -70,7 +71,7 @@ cp $BUILDDIR/RPMS/x86_64/*.rpm ./dist/
# Cross compile because we can
GOBINEXT=""
for GOOS in darwin linux windows; do
- for GOARCH in 386 amd64; do
+ for GOARCH in amd64; do
Review comment:
I think that would be better. I don't think there's anyone trying to do
anything with this on 32-bit machines, but then again I'd reasonably expect to
be able to run a lightweight fake origin on my raspi from high school, so who
knows. If it's easy to not drop support for something valid, I say we do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
