rob05c commented on issue #5125:
URL: https://github.com/apache/trafficcontrol/issues/5125#issuecomment-767008225
Er, what more info do you need? I linked the exact lines of code causing the
crash. They need nil checks.
If `GetCRConfig` returns an error, typically because of an error requesting
TO, those 2 lines will panic and TM will crash. I have observed this crash,
it's not just theoretical.
The fix is to change
```
remoteAddr = reqInf.RemoteAddr.String()
```
to
```
remoteAddr := ""
if reqInf.RemoteAddr != nil {
remoteAddr = reqInf.RemoteAddr.String()
}
```
In those 2 places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
