ocket8888 commented on a change in pull request #5450:
URL: https://github.com/apache/trafficcontrol/pull/5450#discussion_r564696022



##########
File path: 
traffic_portal/app/src/common/modules/table/servers/TableServersController.js
##########
@@ -220,7 +220,7 @@ var TableServersController = function(tableName, servers, 
filter, $scope, $state
                },
                {
                        headerName: "Router Port Name",
-                       field: "routerPortName",
+                       field: "routerPort",

Review comment:
       Yeah, I guess we don't actually need to remove it. It's fair enough to 
represent the router that's used for the IP addresses that we're adding to it.
   
   But I still think the name is wrong. The property name that gets added from 
`toLegacyIPInfo` looks like `routerPortName`, so that'd need to be the name of 
the field to display it properly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to