ocket8888 commented on pull request #5459:
URL: https://github.com/apache/trafficcontrol/pull/5459#issuecomment-768641954


   So, regarding
   
   > 1 issue was detected with this workflow: Please specify an on.push hook so 
that Code Scanning can compare pull requests against the state of the base 
branch.
   
   if I add `on.push` hooks to all of those then we'll be double-testing every 
push to master with each of those workflows _and_ the main/scheduled one.
   
   If it's comparing against the state of master, then maybe we didn't need to 
split these into separate workflows? Because then the runs for languages that 
have no changes won't actually be doing anything, if I'm understanding that 
correctly. The CodeQL web pages aren't helping me understand the action's 
behavior very much, because they're very focused on the parsing tool and don't 
mention this GHA at all, but I can probably contact GitHub support for a more 
thorough explanation


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to