zrhoffman opened a new pull request #5498: URL: https://github.com/apache/trafficcontrol/pull/5498
<!-- ************ STOP!! ************ If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact the Apache Software Foundation Security Team at [email protected] and follow the guidelines at https://www.apache.org/security/ regarding vulnerability disclosure. --> ## What does this PR (Pull Request) do? <!-- Explain the changes you made here. If this fixes an Issue, identify it by replacing the text in the checkbox item with the Issue number e.g. - [x] This PR fixes #9001 OR is not related to any Issue ^ This will automatically close Issue number 9001 when the Pull Request is merged (The '#' is important). Be sure you check the box properly, see the "The following criteria are ALL met by this PR" section for details. --> As a follow-up to #5229, this PR - Adds a GitHub Actions workflow to verify that `go.mod`, `go.sum`, and the `vendor` directory have no uncommitted Git changes when modules are vendored. - Removes an unused dependency and updates `go.sum` - Gets `go mod vendor` to run successfully in the CiaB Traffic Ops `integration` service's Dockerfile by including the `v4-client` directory. Error from `go mod vendor` that is fixed: ```go #29 28.09 github.com/apache/trafficcontrol/traffic_ops/testing/api/v4 tested by #29 28.09 github.com/apache/trafficcontrol/traffic_ops/testing/api/v4.test imports #29 28.09 github.com/apache/trafficcontrol/traffic_ops/v4-client: no matching versions for query "latest" ``` - Gets the Dockerized TO and TM unit tests to working again by including go.mod/go.sum in the Docker image. - [x] is not related to any Issue<!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues --> ## Which Traffic Control components are affected by this PR? <!-- Please delete all components from this list that are NOT affected by this Pull Request. Also, feel free to add the name of a tool or script that is affected but not on the list. Additionally, if this Pull Request does NOT affect documentation, please explain why documentation is not required. --> - CDN in a Box - CI tests ## What is the best way to verify this PR? <!-- Please include here ALL the steps necessary to test your Pull Request. If it includes tests (and most should), outline here the steps needed to run the tests. If not, lay out the manual testing procedure and please explain why tests are unnecessary for this Pull Request. --> * Verify the GitHub Action is working as intended. - Check the result of the *Check Go modules* workflow at 0e54b997ff. The following steps are expected to have failed: * Untracked changes to vendored dependencies * Changes to go.sum - Check the result of the *Check Go modules* workflow at fb9f772b25. It is expected to succeed. * Run the TO API tests in CDN in a Box. On my computer, it took 55 minutes from the time when the API tests started running. ```shell docker-compose -f docker-compose.yml -f docker-compose.traffic-ops-test.yml up --no-deps -d edge dns db smtp trafficops-perl trafficops trafficvault integration; docker-compose -f docker-compose.traffic-ops-test.yml logs -f integration; ``` * Run the Traffic Monitor unit tests in Docker ```shell docker-compose -f traffic_monitor/tests/docker-compose.yml up --build ``` * Run the Traffic Ops unit tests in Docker ```shell docker-compose -f traffic_ops/app/bin/tests/docker-compose.yml up --build ``` ## If this is a bug fix, what versions of Traffic Control are affected? <!-- If this PR fixes a bug, please list here all of the affected versions - to the best of your knowledge. It's also pretty helpful to include a commit hash of where 'master' is at the time this PR is opened (if it affects master), because what 'master' means will change over time. For example, if this PR fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0, and in the current 4.0.1 Release candidate (e.g. RC1), then this list would look like: - master (1df853c8) - 4.0.0 - 4.0.1 (RC1) If you don't know what other versions might have this bug, AND don't know how to find the commit hash of 'master', then feel free to leave this section blank (or, preferably, delete it entirely). --> - master (09e25013fd) ## The following criteria are ALL met by this PR <!-- Check the boxes to signify that the associated statement is true. To "check a box", replace the space inside of the square brackets with an 'x'. e.g. - [ x] <- Wrong - [x ] <- Wrong - [] <- Wrong - [*] <- Wrong - [x] <- Correct! --> - [x] This PR includes tests - [x] This PR includes documentation - [x] An update to CHANGELOG.md is not necessary - [x] This PR includes any and all required license headers - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
