rawlinp opened a new pull request #5513: URL: https://github.com/apache/trafficcontrol/pull/5513
## What does this PR (Pull Request) do? Currently, TM doesn't log an error if it got an invalid monitoring snapshot from TO and a backup file exists. Also TM doesn't log an error if it gets an error fetching a CRConfig snapshot from TO and a backup file exists. This PR makes TM log errors in those cases, because we would need to know the cause of these errors if they were to occur. Also, this PR makes TM consider a monitoring snapshot invalid if there are no delivery services. ## Which Traffic Control components are affected by this PR? - Traffic Monitor ## What is the best way to verify this PR? 1. Starting with a valid crconfig so that TM will create a backup of it, shut down TO so that TM fails to fetch it. TM should log an informative error in this case. 2. Starting with a valid monitoring snapshot so that TM will create a backup of it, delete all delivery services from TO, then snapshot the CDN. This should produce an invalid monitoring snapshot, upon which TM should log an informative error (even though it has a valid backup). ## If this is a bug fix, what versions of Traffic Control are affected? - master - 4.1.x - 5.0.x ## The following criteria are ALL met by this PR - [x] This PR includes tests - [x] bugfix, no docs necessary - [x] This PR includes an update to CHANGELOG.md - [x] This PR includes any and all required license headers - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
