ocket8888 commented on a change in pull request #5514:
URL: https://github.com/apache/trafficcontrol/pull/5514#discussion_r577066210
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/acme.go
##########
@@ -192,7 +191,8 @@ func renewAcmeCerts(cfg *config.Config, dsName string, ctx
context.Context, curr
return nil, nil, http.StatusOK
}
-func getAcmeAccountConfig(cfg *config.Config, acmeProvider string)
*config.ConfigAcmeAccount {
+// GetAcmeAccountConfig returns the ACME account information from cdn.conf for
a given provider
Review comment:
GoDoc comments should end with a `.`
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/autorenewcerts.go
##########
@@ -91,7 +102,16 @@ func RenewCertificates(w http.ResponseWriter, r
*http.Request) {
go RunAutorenewal(existingCerts, inf.Config, ctx, inf.User)
- api.WriteRespAlert(w, r, tc.SuccessLevel, "Beginning async call to
renew Let's Encrypt certificates. This may take a few minutes.")
+ var alerts tc.Alerts
+ if deprecated {
+ alerts.AddAlerts(api.CreateDeprecationAlerts(deprecation))
+ }
+
+ alerts.AddAlert(tc.Alert{
+ Text: "Beginning async call to renew certificates. This may
take a few minutes.",
Review comment:
Looks like an extra space here between "certificates." and "This"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
