rob05c edited a comment on pull request #5537:
URL: https://github.com/apache/trafficcontrol/pull/5537#issuecomment-780903103
So, I'm noticing the `set-header` logic doesn't add its own hook. Which
means it's going to fall under whatever the last hook happens to be, which may
be a response rather than request hook, or it could be an error if there's no
MaxOriginConnections or EdgeHeaderRewrite.
I think it needs to add its own hook like the MaxOriginConnections logic
does above, i.e. `cond %{REMAP_PSEUDO_HOOK}\nset-header ...`
I'm also noticing the CDN-SVC header isn't in
`topologyheaderrewritedotconfig.go`, so it won't be added for Topology DSes.
This PR doesn't introduce either of those issues, so I wouldn't insist it
fix them. If you want to, that'd be great, or if not, whoever merges this
should make Github Issues so we don't forget.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
