ocket8888 commented on a change in pull request #5179:
URL: https://github.com/apache/trafficcontrol/pull/5179#discussion_r578727957
##########
File path: traffic_portal/app/src/common/modules/form/cdn/form.cdn.tpl.html
##########
@@ -41,6 +41,9 @@
<span class="caret"></span>
</button>
<ul class="dropdown-menu-right dropdown-menu"
uib-dropdown-menu>
+ <li ng-if="!cdn.notificationCreatedBy" role="menuitem"><a
ng-click="toggleNotification(cdn)">Create CDN Notification</a></li>
+ <li ng-if="cdn.notificationCreatedBy" role="menuitem"><a
ng-click="toggleNotification(cdn)">Delete CDN Notification</a></li>
Review comment:
Anchor tags should be links - these aren't performing navigation, so
they ought to be `button[type="button"]`s
##########
File path:
traffic_portal/app/src/common/modules/notifications/notifications.tpl.html
##########
@@ -0,0 +1,24 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<div id="notificationsContainer">
+ <div ng-show="cdn.notificationCreatedBy" class="alert alert-info"
ng-repeat="cdn in cdns">
+ <div ng-bind-html="cdn.name + ': ' + cdn.notification + ' (' +
cdn.notificationCreatedBy + ')' | linky:'_blank'"></div>
Review comment:
What is the `linky` pipe doing here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
