ocket8888 commented on a change in pull request #5179:
URL: https://github.com/apache/trafficcontrol/pull/5179#discussion_r583055015
##########
File path: traffic_portal/app/src/common/modules/header/header.tpl.html
##########
@@ -40,7 +40,7 @@
<li role="presentation" class="dropdown"
ng-if="hasCapability('change-logs-read')">
<div class="btn-group" title="Change Logs" uib-dropdown
is-open="alerts.isopen">
<button id="alertsButton" type="button" class="btn
btn-link" ng-click="getChangeLogs()" uib-dropdown-toggle>
- <i class="fa fa-comment-o"></i>
+ <i class="fa" ng-class="{ 'fa-comment': newLogCount()
> 0, 'fa-comment-o': newLogCount() == 0 }"></i>
Review comment:
Oh, that's because it doesn't need the curly braces. It's not an object
anymore. My bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]