jrushford commented on a change in pull request #5706: URL: https://github.com/apache/trafficcontrol/pull/5706#discussion_r608137234
########## File path: traffic_ops_ort/testing/docker/trafficserver/trafficserver-8.spec ########## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# SPDX-License-Identifier: Apache-2.0 +# +%global src %{_topdir}/SOURCES/trafficserver +%global git_args --git-dir="%{src}/.git" --work-tree="%{src}" +%global git_tag %(git %{git_args} describe --long | sed 's/^\\\(.*\\\)-\\\([0-9]\\\+\\\)-g\\\([0-9a-f]\\\+\\\)$/\\\1/' | sed 's/-/_/') +%global distance %(git %{git_args} describe --long | sed 's/^\\\(.*\\\)-\\\([0-9]\\\+\\\)-g\\\([0-9a-f]\\\+\\\)$/\\\2/') +%global commit %(git %{git_args} describe --long | sed 's/^\\\(.*\\\)-\\\([0-9]\\\+\\\)-g\\\([0-9a-f]\\\+\\\)$/\\\3/') Review comment: @zrhoffman I'd prefer to keep the spec files as they are. These are basically copies of the ones we use to build the production RPM's today and we've been using them for years. if you look in the trafficcontrol code base these two have all the backslashes too, `./traffic_server/_tsb/trafficserver.spec ./traffic_server/spec/trafficserver.spec`. The point is that I'd like to I'd like to keep the SPEC files as nearly identical as the ones we use for production. Is this alright with you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
