ocket8888 commented on a change in pull request #5934: URL: https://github.com/apache/trafficcontrol/pull/5934#discussion_r651162261
########## File path: traffic_portal/app/src/common/modules/dialog/select/lock/dialog.select.lock.tpl.html ########## @@ -0,0 +1,69 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<div class="modal-header"> + <button type="button" class="close" ng-click="cancel()"><span aria-hidden="true">×</span><span class="sr-only">Close</span></button> + <h4 class="modal-title">Create CDN Lock</h4> +</div> +<div class="modal-body"> + <form name="lockForm" novalidate> + <div class="row"> + <div class="col-sm-12 col-md-12"> + <div class="form-group" ng-class="{'has-error': hasError(lockForm.cdn), 'has-feedback': hasError(lockForm.cdn)}"> + <label class="control-label" for="cdn">CDN * + <small class="input-error" ng-show="hasPropertyError(lockForm.cdn, 'required')">Required</small> + </label> + <select id="cdn" name="cdn" class="form-control" ng-model="lock.cdn" ng-options="cdn.name as cdn.name for cdn in cdns" required> + <option value="">Select...</option> + </select> + </div> + </div> + </div> + <div class="row"> + <div class="col-sm-12 col-md-12"> + <div class="form-group" ng-class="{'has-error': hasError(lockForm.message), 'has-feedback': hasError(lockForm.message)}"> + <label class="control-label" for="message">Message * + <small class="input-error" ng-show="hasPropertyError(lockForm.message, 'maxlength')">Too Long</small> + </label> + <input id="message" name="message" type="text" class="form-control" ng-model="lock.message" ng-maxlength="256" required autofocus> + <span ng-show="hasError(lockForm.message)" class="form-control-feedback"><i class="fa fa-times"></i></span> + </div> + </div> + </div> + <div class="row"> + <div class="col-sm-12 col-md-12"> + <div class="form-group"> + <p>Type *</p> + <input id="soft" type="radio" data-ng-model="lock.soft" data-ng-value="true"> + <label class="has-tooltip" for="soft"> Soft<div class="helptooltip"> + <div class="helptext">A soft lock will prevent others from queueing server updates or snapshotting the locked CDN.</div> + </div> + </label><br> + <input id="hard" type="radio" data-ng-model="lock.soft" data-ng-value="false"> + <label class="has-tooltip" for="soft"> Hard<div class="helptooltip"> + <div class="helptext">A hard lock will prevent others from queueing server updates or snapshotting the locked CDN. It will also block others from making changes that would change the state of the locked CDN.</div> + </div> + </label> + </div> + </div> + </div> + </form> +</div> +<div class="modal-footer"> Review comment: you shouldn't have to do any styling - although you're right that you would. The `modal-footer` class should handle all the necessary styling, but there's some specific styling for `footer` elements in `theme.scss` that would interfere - which really ought to not be doing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
