ocket8888 commented on a change in pull request #5924:
URL: https://github.com/apache/trafficcontrol/pull/5924#discussion_r652104151
##########
File path: lib/go-tc/deliveryservice_ssl_keys.go
##########
@@ -73,6 +73,7 @@ type SSLKeyRequestFields struct {
HostName *string `json:"hostname,omitempty"`
Country *string `json:"country,omitempty"`
State *string `json:"state,omitempty"`
+ Version *int `json:"version,omitempty"`
Review comment:
> I believe we are free to add new fields to existing structs -- that is
a non-breaking change.
Not only that, but it looks like the "new" field was used in older API
versions already, the only difference is that the Go client used to hard-code
it. So this is barely a **non**-breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
