dmohan001c commented on pull request #5961:
URL: https://github.com/apache/trafficcontrol/pull/5961#issuecomment-865052484


   > I don't think this can actually be fixing it - after digging into the 
issue in #5957 I've found that the returned ordering actually does differ from 
how Go sorts strings, so this shouldn't be fixable with just changing how the 
entrypoint script exits.
   > 
   > I'm not sure how, but it appears that this PR is merely hiding the exit 
code again. Because you can see in the [checks output from this 
PR](https://pipelines.actions.githubusercontent.com/SkCuvZ6pt0n8Mrp79gaiS27VlL7eMS1136UzeqF4MLjw7Edjex/_apis/pipelines/1/runs/20368/signedlogcontent/3?urlExpires=2021-06-21T13%3A34%3A25.5669918Z&urlSigningMethod=HMACV1&urlSignature=n81FlQRSuWnnlPj%2BmPCd59uk4veE21uBTVxbknXrurU%3D):
   > 
   > ```
   > 2021-06-21T13:11:02.3551335Z === CONT  TestDeliveryServices
   > 2021-06-21T13:11:02.3554092Z     deliveryservices_test.go:2288: list is 
not sorted by their XML Id: [anymap-ds ds1 ds1nat ds2 ds3 ds4 
ds-based-top-with-no-mids ds-client-steering ds-forked-topology 
ds-test-minor-versions ds-top ds-top-req-cap ds-top-req-cap2 inactiveds msods1 
test-ds-server-assignments top-ds-in-cdn1 top-ds-in-cdn2]
   > 2021-06-21T13:11:05.1781439Z --- FAIL: TestDeliveryServices (15.64s)
   > 2021-06-21T13:11:05.1783004Z     --- PASS: 
TestDeliveryServices/Missing_slice_plugin_size (0.00s)
   > 2021-06-21T13:11:05.1784519Z     --- PASS: 
TestDeliveryServices/Slice_plugin_size_set_with_incorrect_range_request_setting 
(0.00s)
   > 2021-06-21T13:11:05.1786052Z     --- PASS: 
TestDeliveryServices/Slice_plugin_size_set_to_small (0.00s)
   > 2021-06-21T13:11:05.1787369Z     --- PASS: 
TestDeliveryServices/Slice_plugin_size_set_to_large (0.00s)
   > ```
   
   Okay. what would be the solution., Sometimes it's getting passed and failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to