rob05c commented on a change in pull request #5964:
URL: https://github.com/apache/trafficcontrol/pull/5964#discussion_r660157102
##########
File path: cache-config/t3c-apply/torequest/torequest.go
##########
@@ -893,6 +897,10 @@ func (r *TrafficOpsReq) ProcessConfigFiles()
(UpdateStatus, error) {
}
}
+ if 0 < len(r.changedFiles) {
Review comment:
Nitpick: this is an artifact of C, it isn't necessary in Go, `len(x) >
0` is easier to read and understand.
(Assignment has no return value in Go, so `if x = 0 {` doesn't compile.)
##########
File path: cache-config/t3c-apply/torequest/torequest.go
##########
@@ -893,6 +897,10 @@ func (r *TrafficOpsReq) ProcessConfigFiles()
(UpdateStatus, error) {
}
}
+ if 0 < len(r.changedFiles) {
Review comment:
Nitpick: this is an artifact of C, it isn't necessary in Go, `len(x) >
0` is easier to read and understand.
(Assignment is not an expression in Go, so `if x = 0 {` doesn't compile.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
