rawlinp commented on a change in pull request #5986:
URL: https://github.com/apache/trafficcontrol/pull/5986#discussion_r661775786
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -339,6 +339,13 @@ type DeliveryServiceRemovedFieldsV11 struct {
CacheURL *string `json:"cacheurl" db:"cacheurl"`
}
+// RemoveLD1AndLD2 removes the Long Description 1 and Long Description 2
fields from a V 4.x DS, and returns the resulting struct.
+func (ds *DeliveryServiceV4) RemoveLD1AndLD2() DeliveryServiceV4 {
+ ds.LongDesc1 = nil
+ ds.LongDesc2 = nil
+ return *ds
+}
+
Review comment:
That would break how his implementation works. It optionally
inserts/updates those fields depending on which API version was requested, so
we can't set them to nil in `UpgradeToV4` which is used in `createV31` and
`updateV31`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
