zrhoffman opened a new issue #5991: URL: https://github.com/apache/trafficcontrol/issues/5991
<!-- ************ STOP!! ************ If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact the Apache Traffic Control Security Team at [email protected] and follow the guidelines at https://www.apache.org/security/ regarding vulnerability disclosure. - For *SUPPORT QUESTIONS*, use the #traffic-control channel on the ASF slack (https://s.apache.org/slack-invite) or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists). - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. --> ## I'm submitting a ... <!-- delete all those that don't apply --> <!--- security vulnerability (STOP!! - see above)--> - bug report ## Traffic Control components affected ... <!-- delete all those that don't apply --> - GitHub Actions ## Current behavior: <!-- Describe how the bug manifests --> The *Go Vet* GitHub Actions workflow uses a step named `go-version` to set an output named `value` to the value of the [`GO_VERSION`](https://github.com/apache/trafficcontrol/blob/master/GO_VERSION) file: https://github.com/apache/trafficcontrol/blob/5227543eb527ed2365aa86f9037d0c35bd4a448b/.github/workflows/go.vet.yml#L43-L44 But because the `id` of that step is not set to `go-version`, when the next step tries to set the `go-version` input to the value of `steps.go-version.outputs.value` https://github.com/apache/trafficcontrol/blob/5227543eb527ed2365aa86f9037d0c35bd4a448b/.github/workflows/go.vet.yml#L45-L47 that value is an empty string. ## Expected behavior: <!-- Describe what the behavior would be without the bug --> The `id` of the `go-version` step needs to be set to `go-version` instead of the `name` (and `name` can be changed to something more readable). ## Minimal reproduction of the problem with instructions: <!-- If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and include the applicable TC version. --> 1. In the GitHub web UI for the apache/trafficcontrol repo, go to *Actions* -> *Go Vet* -> The latest run in the list -> `go-vet` 2. Expand the *Run actions/setup-go@v2* step and see that the `go-version` input is not set:  <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at https://apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
