zrhoffman opened a new issue #5995: URL: https://github.com/apache/trafficcontrol/issues/5995
<!-- ************ STOP!! ************ If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact the Apache Traffic Control Security Team at [email protected] and follow the guidelines at https://www.apache.org/security/ regarding vulnerability disclosure. - For *SUPPORT QUESTIONS*, use the #traffic-control channel on the ASF slack (https://s.apache.org/slack-invite) or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists). - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. --> ## I'm submitting a ... <!-- delete all those that don't apply --> <!--- security vulnerability (STOP!! - see above)--> - improvement request (usability, performance, tech debt, etc.) ## Traffic Control components affected ... <!-- delete all those that don't apply --> - GitHub Actions ## Current behavior: <!-- Describe how the current features are insufficient. --> A number of our GitHub Actions' shell scripts include code to check the Go version in `GO_VERSION` and download that version. ## New behavior: <!-- Describe how the feature would improve Traffic Control --> Go version should be be set in the workflow files by 1. Checking the version in the `GO_VERSION` file: https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/workflows/go.vet.yml#L43-L44 Note that `id` also needs to be set for this step (see #5991). 2. Using the [actions/setup-go](https://github.com/actions/setup-go) action with that version. https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/workflows/go.vet.yml#L45-L47 ## Minimal reproduction of the problem with instructions: <!-- If you can illustrate your feature request better with an example, please provide the *STEPS TO REPRODUCE* and include the applicable TC version. If not, feel free to delete this section. --> https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/check-go-modules/entrypoint.sh#L89-L90 https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/check-go-modules/entrypoint.sh#L95 https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/go-fmt/entrypoint.sh#L29 https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/go-test/entrypoint.sh#L31 https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/pr-to-update-go/update_golang_org_x.sh#L41-L45 https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/tm-integration-tests/entrypoint.sh#L76-L78 https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/todb-init/entrypoint.sh#L29 https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/to-integration-tests/entrypoint.sh#L101-L103 https://github.com/apache/trafficcontrol/blob/f691cd9c828ee1ae8bcb5ecc68f0052475dad427/.github/actions/tp-integration-tests/entrypoint.sh#L156-L158 <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at https://apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
