zrhoffman commented on pull request #5539: URL: https://github.com/apache/trafficcontrol/pull/5539#issuecomment-876733076
> Usages in cache-config/ are in GoDoc comments > Usage in lib/go-tc is in GoDoc comments > In tosession.py it's in a comment on an example - which itself works afaik - and doesn't appear in any documentation. > Usage in traffic_ops/testing/ is in non-documenting comments > The URL used in the DS Stats test is arbitrary Updating all of these makes sense to me, IMO. > cfg_test.pl is a script that, I believe, has not worked for longer than your involvement in the project. Possibly longer than mine. It was replaced by the compare tool, which has since been removed because it no longer serves any purpose. This script should not exist. Sounds like it could have been removed in the Perlectomy. Removing it with the rest of API v1 is the next best thing, right? --- > Usage in Grove is in a comment that wouldn't even appear in package documentation. I can get rid of it if you want, but it's not affecting anything. https://github.com/apache/trafficcontrol/blob/1c72915665192d9ffa4d08e5ba202e044b38c2be/grove/grovetccfg/grovetccfg.go#L195 I'm seeing more API v1 stuff lower down: https://github.com/apache/trafficcontrol/blob/1c72915665192d9ffa4d08e5ba202e044b38c2be/grove/grovetccfg/grovetccfg.go#L232-L265 Removing the Grove API v1 stuff would make more sense in a separate PR. > Usage in the ORT.py package is irrelevant, since that is due for removal. > I don't tend to touch anything in infrastructure/docker (except in the build subdirectory) because those Dockerfiles are archaic, they're parsing that API output in a way that may not be trivial (e.g. getting/setting server IP addresses), and their use is nowhere recommended or even documented. > Usage in load-test.jsx is not referring to a Traffic Ops host - you can tell because it's passing a hostname for a Traffic Ops instance as a query parameter. test/router/server.go is the server serving that API, so the only real change necessary should be in there. But on the other hand - that test suite doesn't work. All browsers I've tried (Firefox, Chrome, Opera, all at latest versions) will refuse to load the .jsx file on the grounds of CORS request failure. If those tests are intended to work, they'll need to be reworked anyway, so the changes could just take place then. > Swagger is not actually supported by Traffic Ops. The traffic_ops/traffic_ops_golang/swaggerdocs/ directory and any and all sub-packages thereof should be deleted, in my opinion. Unless someone is going to make them work, in which case they ought to update them to be correct themselves. Agreed that taking care of these outside of #5339 makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
