ocket8888 commented on a change in pull request #6012:
URL: https://github.com/apache/trafficcontrol/pull/6012#discussion_r670771612
##########
File path: traffic_portal/test/integration/PageObjects/SideNavigationPage.po.ts
##########
@@ -54,6 +54,10 @@ export class SideNavigationPage extends BasePage{
private lnkCoordinates = element(by.xpath("//a[@href='/#!/coordinates']"));
private lnkRegions = element(by.xpath("//a[@href='/#!/regions']"));
private lnkASNs = element(by.xpath("//a[@href='/#!/asns']"));
+ //Navigation for Jobs
+ private propTools =
"//div[@id='sidebar-menu']//a[contains(text(),'Tools')]"
Review comment:
CSS selectors are easier to read and understand than XPath, the
equivalent of this would be `element.byCSSContainingText("#sidebar-menu a",
"Tools"`)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
