srijeet0406 commented on a change in pull request #6003:
URL: https://github.com/apache/trafficcontrol/pull/6003#discussion_r694067290
##########
File path: traffic_ops/testing/api/v3/profiles_test.go
##########
@@ -90,8 +89,7 @@ func GetTestProfilesIMS(t *testing.T) {
if len(respParameter) > 0 {
parameterID := respParameter[0].ID
if parameterID > 0 {
- t.Errorf("Parameter ID %d", parameterID)
- resp, _, err :=
TOSession.GetProfileByParameterWithHdr(strconv.Itoa(parameterID), header)
+ resp, _, err :=
TOSession.GetProfileByParameterWithHdr(parameterID, nil)
Review comment:
You can't actually change the existing client signatures because that
breaks the clients that are using them. I suggest creating a new method that
takes in the parameterID, instead of the parameter name, and then using that
method in the tests. You can leave the `GetProfileByParameterWithHdr` method as
it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
