zrhoffman commented on a change in pull request #6532:
URL: https://github.com/apache/trafficcontrol/pull/6532#discussion_r801818366



##########
File path: dev/traffic_ops/Dockerfile
##########
@@ -0,0 +1,38 @@
+#
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+#
+FROM alpine:latest AS certbuilder
+RUN apk add --no-cache openssl
+RUN openssl genrsa -passout pass:x -out server.pass.key 2048 && \
+       openssl rsa -passin pass:x -in server.pass.key -out server.key && \
+       rm server.pass.key && \
+       openssl req -new -key server.key -out server.csr \
+               -subj "/C=US/ST=CO/L=Denver/O=Apache/OU=Traffic 
Control/CN=trafficops.dev.ciab.test" && \
+       openssl x509 -req -days 365 -in server.csr -signkey server.key -out 
server.crt && \
+       openssl rand 32 | base64 > /aes.key
+
+FROM alpine:latest AS trafficops-dev
+
+ENV TC="/root/go/src/github.com/apache/trafficcontrol/"
+VOLUME /root/go/src/github.com/apache/trafficcontrol
+ENV ADMIN="$TC/traffic_ops/app/db/admin"
+EXPOSE 443 6444
+
+COPY --from=certbuilder /server.key /server.crt /aes.key /
+RUN apk add --no-cache make inotify-tools go postgresql-client && go install 
github.com/go-delve/delve/cmd/dlv@latest && ln -s /root/go/bin/dlv /usr/bin/dlv

Review comment:
       > That means either expanding the build scope to include the entire ATC 
repo or deferring the installation of Go to run-time in at least 3 containers. 
I'd rather not do either of those things, and if you update the cached layer 
where Go is installed, you should get 1.17.6.
   
   Expanding the build scope does not need to be a performance hit if you 
ignore everything in a dockerignore, excepting files/directories that you want 
the image to include: https://docs.docker.com/engine/reference/builder/#usage




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to