ocket8888 commented on pull request #6669: URL: https://github.com/apache/trafficcontrol/pull/6669#issuecomment-1071471506
> Yes the GHAs run the TO API tests, but this failure is not in GHA, so we lose test coverage by removing it from CiaB. Sure, but that's unintentional. My understanding is the two are supposed to be equivalent. They're both running the same test suite, after all. And is it really "test coverage" the tests are never being run and nobody knows when they fail? > We need to pay better attention to it We could - or we could figure out what cases it's covering that aren't covered by existing automation and absorb those. On that note, I have no idea what those are. I'm truly puzzled why it's failing (and inconsistently, too) in this CiaB extension and not in general. Whatever we do with this test suite, we'll need to figure that out. <hr/> All else aside, it is true that when I ran the tests they skipped APIv1. So this PR does what it says it does and presumably helps the tests get closer to a passing state. I'll merge it if you want, but at some point we gotta figure out why they fail for us locally and then either fix them or figure out what needs to be done to other tests to make sure these don't cover a gap somewhere else. So you could add that to this PR if you want, but it's good to go as-is as far as I'm concerned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
