ocket8888 commented on a change in pull request #6675:
URL: https://github.com/apache/trafficcontrol/pull/6675#discussion_r830222032
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go
##########
@@ -956,8 +956,11 @@ func (dss *TODSSDeliveryService) Read(h http.Header,
useIMS bool) ([]interface{}
for _, ds := range dses {
if version.Major > 3 && version.Minor >= 0 {
ds = ds.RemoveLD1AndLD2()
+ returnable = append(returnable, ds)
+ } else {
+ dsV3 := ds.DowngradeToV3()
+ returnable = append(returnable, dsV3)
Review comment:
`DowngradeToV3` downgrades to an APIv3.1 structure - _even though it's
named `DeliveryServiceNullableV30`!_
From that type's GoDoc:
> Again, this type is an alias that refers to the LATEST MINOR VERSION of
API version 3 - NOT API version 3.0 as the name might imply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
